"Reedy" posted a comment on MediaWiki.r110122.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110122#c30105
Commit summary for MediaWiki.r110122:
Fix undefined $dirRoot
Reedy's comment:
Somewhat
<pre>
if ( !empty( $params['noAccess'] ) ) {
if ( !file_exists( "{$contRoot}/.htaccess" ) ) {
wfSuppressWarnings();
- $ok = file_put_contents(
"{$dirRoot}/.htaccess", "Deny from all\n" );
+ $ok = file_put_contents(
"{$contRoot}/.htaccess", "Deny from all\n" );
</pre>
It uses contRoot in a file exists call, and if it doesn't exist, attempting to
create said file at that location makes sense..
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
