"MarkAHershberger" posted a comment on MediaWiki.r110122.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110122#c30111
Commit summary for MediaWiki.r110122:
Fix undefined $dirRoot
MarkAHershberger's comment:
Right, but my question was based on how $dir is set up:
$dir = ( $dirRel != '' ) ? "{$contRoot}/{$dirRel}" : $contRoot;
And the fact that index.html is checked for in $dir, not $contRoot.
Nevertheless, I think getting Aaron to check it (as you suggest) would be best.
(Maybe he could clarify $dir and $contRoot in the comments.)
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
