"Tim Starling" changed the status of MediaWiki.r110073 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/110073#c30324
Old Status: new > New Status: ok Commit summary for MediaWiki.r110073: Further reduced RTTs in SwiftFileBackend by making "file already exists" checks use the stat cache, typically already set in FileOp::doPrecheck(). FileBackendBase::doOperationsInternal() already clears the cache after locking (and before FileOp::attemptBatch) for consistency. Tim Starling's comment: Optional boolean parameters which default to false are one of the few acceptable applications of empty(). Aaron added lots of them in the FileBackend project, probably just to annoy empty-haters ;) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
