"Tim Starling" changed the status of MediaWiki.r109980 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109980#c30325
Old Status: new > New Status: ok Commit summary for MediaWiki.r109980: In FileBackend: * Use 'b' param in some fopen() calls as needed for Windows and newline handling. * Removed some useless padding code in FileBackend::getContainerShard(). Initialized $m to make IDE happy. * Updated some code comments. In SwiftFileBackend: * Manually set the ETag when using php-cloudfiles for creating files to avoid https://github.com/rackspace/php-cloudfiles/issues/59. * Manually set the content type based on how StreamFile::getType(). This makes it safe to read files directly out of the proxy to end-users. The streamFile() backend functions already uses a similar content-type check. Tim Starling's comment: I may have misled you a bit with my outdated knowledge of binary mode: "As of PHP 4.3.2, the default mode is set to binary for all platforms that distinguish between binary and text mode." [http://au2.php.net/manual/en/function.fopen.php]. Oh well, it's harmless. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
