"Reedy" changed the status of MediaWiki.r109884 to "fixme" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/109884#c30433
Old Status: reverted
> New Status: fixme
Commit summary for MediaWiki.r109884:
move Mobile Frontend class to separate body file
Reedy's comment:
<pre>
Fatal error: Class 'ExtMobileFrontend' not found in
/home/reedy/mediawiki/trunk/extensions/MobileFrontend/MobileFrontend.php on
line 82 Call Stack: 0.0001 641304 1. {main}()
/home/reedy/mediawiki/trunk/phase3/mw-config/index.php:0 0.0109 3088616 2.
wfInstallerMain() /home/reedy/mediawiki/trunk/phase3/mw-config/index.php:18
0.1917 8883616 3. WebInstaller->execute()
/home/reedy/mediawiki/trunk/phase3/mw-config/index.php:50 0.1972 9179808 4.
WebInstaller_ExistingWiki->execute()
/home/reedy/mediawiki/trunk/phase3/includes/installer/WebInstaller.php:254
0.1972 9179808 5. Installer::getExistingLocalSettings()
/home/reedy/mediawiki/trunk/phase3/includes/installer/WebInstallerPage.php:250
0.2000 9622880 6.
require('/home/reedy/mediawiki/trunk/phase3/LocalSettings.php')
/home/reedy/mediawiki/trunk/phase3/includes/installer/Installer.php:479 0.2159
10501136 7.
require_once('/home/reedy/mediawiki/trunk/extensions/MobileFrontend/MobileFrontend.php')
/home/reedy/mediawiki/trunk/phase3/LocalSettings.php:228
</pre>
Having the extension enabled and loaded gave the above bork when trying to use
the installer again
I'm guessing it's the code below, trying to instantiate a class that isn't
actually loaded into scope yet...
<pre>
$wgExtMobileFrontend = new ExtMobileFrontend();
$wgHooks['BeforePageDisplay'][] = array( &$wgExtMobileFrontend,
'beforePageDisplayHTML' );
$wgHooks['BeforePageRedirect'][] = array( &$wgExtMobileFrontend,
'beforePageRedirect' );
$wgHooks['SkinTemplateOutputPageBeforeExec'][] = array( &$wgExtMobileFrontend,
'addMobileFooter' );
$wgHooks['TestCanonicalRedirect'][] = array( &$wgExtMobileFrontend,
'testCanonicalRedirect' );
</pre>
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
