"Aaron Schulz" changed the status of MediaWiki.r96546 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96546#c30434
Old Status: resolved > New Status: fixme Commit summary for MediaWiki.r96546: Enabled MoveLogFormatter -> This brings better i18n even to existing move log entries Fixed the class name from r96441, it's Move not Block Added notes about new naming conventions to DefaultSettings.php -> didn't bother the remain existing messages now, they will keep working Didn't remove 1movedto2*, they are still used until I commit the code which actually makes new style log entries. Aaron Schulz's comment: In LogPage we have: <pre>$rv = call_user_func_array( $wgLogActionsHandlers[$key], $args );</pre> But $wgLogActionsHandlers is being set to uses class names as callbacks, not functions. I get things like: <b>Warning</b>: call_user_func_array() expects parameter 1 to be a valid callback, function 'DeleteLogFormatter' not found or invalid function name in <b>D:\www\MediaWiki\phase3\includes\logging\LogPage.php</b> on line <b>296</b><br /> _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
