"Krinkle" posted a comment on MediaWiki.r111378.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111378#c31216

Commit summary for MediaWiki.r111378:

[RL] Comment mod and other minor changes
_ Add comment about why it casts to (object)
- Modify function comment
- Whitespace (start the function body on a new line in debug mode. In 
production mode this is trimmed away afterwards)
- Remove the jQuery->$ passage from loader. There is already a global alias for 
$ by jQuery, and aside from that every module has it's own (function(){}) 
wrapper that aliases it from jQuery (not from $), so there is no performance 
gain either by having it locally here since it doesn't use that.

Krinkle's comment:

Well, if that's the use case of this alias. Then what about 
<code>jQuery</code>, <code>mw</code>, <code>mediaWiki</code>, 
<code>document</code> or perhaps even <code>window</code> ?

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to