"Krinkle" posted a comment on MediaWiki.r112453. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112453#c31479
Commit summary for MediaWiki.r112453: Re-add the exception log removed in r88392: unlike Chrome, the current Firebug displays exceptions dumped in this way with full details, including a backtrace Krinkle's comment: r88392 removed the console.log(e) and added a throw. Which made it trigger debug workflows for exceptions in all debuggers (instead of just Firebug), but also made it catchable from unit tests such as QUnit. r112451 removed the throw leaving no debug hook for exceptions and this revision re-adds the console log line. I'll check out if it's a problem to throw exceptions from execute() (which r88392 intended to do and was reviewed), if it's ok I'll swap it for throw again, okay ? (effectively re-applying r88392) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
