"Tim Starling" posted a comment on MediaWiki.r112453.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112453#c31485

Commit summary for MediaWiki.r112453:

Re-add the exception log removed in r88392: unlike Chrome, the current Firebug 
displays exceptions dumped in this way with full details, including a backtrace

Tim Starling's comment:

Yes, I think rethrowing the exception is the best option, at least in the short 
term. In theory, it's possible to catch exceptions to allow unrelated modules 
to continue to work, but the existing code is not sufficient to make that 
happen. The whole loop in handlePending() is aborted when an exception is 
thrown, but the module responsible is does not have its state set to "error", 
only the innocent module which called execute() 

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to