"Wikinaut" posted a comment on MediaWiki.r112451. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112451#c31480
Commit summary for MediaWiki.r112451: * Fix r111983 (bug 34662): make mw.toolbar.addButton() work even after DOM ready * Don't use an empty array as the default for $toolbar, use false which will throw an exception on a logic error. * Fix exception handling in mw.loader: have handlePending() rethrow its exception so that the exception handler in execute() can run, so that the exception gets logged. But don't rethrow the exception in execute(), because that may break other modules. Wikinaut's comment: this fixes at least bug34662 "no toolbar (editbar) icons in trunk since r111983" (closed now). _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
