"Catrope" changed the status of MediaWiki.r112599 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112599#c31571
Old Status: new New Status: fixme Commit summary for MediaWiki.r112599: bug 34090 - follow up to r111211 - rename things to make them "less confusing" - only they're still confusing - comment copiously, return if the pageid is bogus Catrope's comment: <pre> + $page_name = $title_object->getPartialURL(); </pre> Sorry for not noticing this earlier: you should really use ->getText() here. Never feed URL-encoded things back into Title constructors, that'll fail if there are URL-unsafe characters in the title. OK otherwise. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
