"Robmoen" changed the status of MediaWiki.r112599 to "ok" and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112599#c31572
Old Status: fixme
New Status: ok
Commit summary for MediaWiki.r112599:
bug 34090 - follow up to r111211 - rename things to make them "less confusing"
- only they're still confusing - comment copiously, return if the pageid is
bogus
Robmoen's comment:
<pre>
if (!$title_object) {
return;
}
</pre>
Since Title::newFromID returns null or a string, wouldn't it be better to use
exact type comparison ? Like:
<pre>
if( $title_object === null ) {
return;
}
</pre>
Otherwise ok.
_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
