"Khorn (WMF)" posted a comment on Wikimedia.r1377. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1377#c31598
Commit summary for Wikimedia.r1377: Fixing several issues. See r1212. Khorn (WMF)'s comment: In the function _civicrm_recurring_globalcollect_update_record, you call _civicrm_recurring_globalcollect_validate_record_for_update before you call the recursive function _civicrm_recurring_globalcollect_get_next_sched_contribution_date_for_month, which is still doing a lot of unnecessary near-constant operations and internal validation, including calling _civicrm_recurring_globalcollect_update_record again. There is still some ground to cover to make this recursion as safe and efficient as possible. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
