"Khorn (WMF)" posted a comment on Wikimedia.r1377. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1377#c31611
Commit summary for Wikimedia.r1377: Fixing several issues. See r1212. Khorn (WMF)'s comment: Over in .module, the function civicrm_recurring_globalcollect_process_error probably needs to control whether or not we should halt execution altogether, or go ahead and try the next record. Halting errors are probably things like bad configuration of the instance, or not being able to reach Globalcollect at all: The types of errors that would basically make it impossible to continue usefully. The ones where we would want to charge ahead with the next thing, would be issues like strange responses from globalcollect (but not 404s), missing parameters, and strange data. In all cases, though, it would probably be useful to generate that failmail, which it looks like you're already doing. :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
