"QChris" posted a comment on MediaWiki.r112598.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112598#c31667

Commit summary for MediaWiki.r112598:

Follow-up r112565: fix code duplication

QChris's comment:

This refactoring looks somewhat like an oversimplification.

It sets $this->mConn to ''false'', for all backends upon closure. However, most 
backends used ''null'' for “no connection set” instead of ''false''.


_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to