"QChris" posted a comment on MediaWiki.r112598. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112598#c31682
Commit summary for MediaWiki.r112598: Follow-up r112565: fix code duplication QChris's comment: Besides, this refactoring factors out logic into the abstract base class -- i.e. handling/meaning of <code>mConn</code> -- that is inherently bound to backend implementation and is different from backend implementation to backend implementation. Before this refactoring, it appeared to me, that <code>mConn</code> is under the sole discretion of the backend implementation. The refactoring silently breaks this clear separation without adding documentation about it. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
