"Krinkle" posted a comment on MediaWiki.r113800. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113800#c32142
Commit summary for MediaWiki.r113800: Impliment getModifiedTime for ResourceLoaderLanguageDataModule, using CACHE_ANYTHING, store md5 hash of the grammarforms and compare the hash to see if it is modified. (Code mostly written by Niklas) Ping r112991 Krinkle's comment: <pre> + $key = wfMemckey( 'rllangdatacache' ); </pre> <code>wfMemcKey</code> takes several arguments to create a fake-hierarchy in the cache. Most calls in ResourceLoader use <code>'resourceloader', 'group', 'exact key', 'optional variation'</code>. Suggesting something like <code>wfMemcKey( 'resourceloader', 'langdatamodule', 'changeinfo' );</code> (not using <code>langdatacache</code> since it's not a cache of the language data itself, but of the hash and a timestamp). Also the function is called <code>wfMemc<strong>K</strong>ey</code>, makes it easier to find with standard <code>ack-grep</code> :) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
