"Nikerabbit" posted a comment on MediaWiki.r113800. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113800#c32156
Commit summary for MediaWiki.r113800: Impliment getModifiedTime for ResourceLoaderLanguageDataModule, using CACHE_ANYTHING, store md5 hash of the grammarforms and compare the hash to see if it is modified. (Code mostly written by Niklas) Ping r112991 Nikerabbit's comment: For the reviewer: We discussed this together for a while and thought about using l10n cache and other caches, but those all use DepedencyWrapper which doesn't provide way to get timestamps of last change (some Dependency objects don't even store that), and using file timestamps doesn't work if l10n cache is in the database. And GlobalDependency stores the actual global value in cache, which in this case is unnecessarily large, so we went with a hash, which hopefully is fast enough for this purpose. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
