"Catrope" changed the status of MediaWiki.r113272 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113272
Old status: new New status: ok Commit summary for MediaWiki.r113272: [Html::namespaceSelector] Remove default id/name attributes * Remove default id/name attributes * Remove now redundant tests introduced in r110274 * Add tests to make sure label has no 'for' attribute when label isn't null but name/id are unset * Update tests to not include id="" and name="" when calling with no arguments * Updating calls to add name/id if needed, and while at it remove useless 'null' params * Context: -- Introduced in r109990, r111376, r111315 -- No callers exist that assume these defaults. Forcing an ID that should be unique is annoying and redundant. The name used in the query when submitting a form should be mentioned in the same file where it is used from the submission, never assume what name="" is from unrelated code -- Same for ID, this is often used in CSS or JavaScript, shouldn't be assumed. (It should be simple to but two simple namespace selectors on a page without getting DOM conflicts) _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
