"Catrope" changed the status of MediaWiki.r113352 to "ok"
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113352

Old status:  new
New status: ok

Commit summary for MediaWiki.r113352:

[NewUserMessage] Don't prepend 2 empty lines before the Welcome template
* First line, meant to offset from potentially pre-existent content. Aside from 
the fact that the caller of this function only runs if !$talk->exists(), it 
could potentially exist later in a race condition (I've never seen this happen, 
but the code is already checking for that case where it prepends getRawText()), 
moved the first newline to there.
* Second line, meant to offset from the ==subject==, moved to within the if 
statement

* Fixes:
-- (bug 35058) [Regression] Don't prepend 2 empty lines before the Welcome 
template

_______________________________________________
MediaWiki-CodeReview mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to