"Valhallasw" posted a comment on pywikipedia.r10036. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10036#c32472
Commit summary for pywikipedia.r10036: New -overwrite=[yes|no] option for djvutext Patch by Lars Aronsson <[email protected]> Reference: pywikipediabot-Patches-3502676 Valhallasw's comment: Hm, yes. After discussing with Lars the if-block made sense yesterday, but I'm unsure about it now. Just to describe what the options do: -ask: also ask if the page is new -overwrite: never/always create/overwrite the page which is indeed somewhat confusing. Maybe having both -create:<yes/no/ask> and -overwrite:<yna> and deprecating -ask (which then is equal to -create:ask) would be the best...? -overwrite without parameters should either be the same as -overwrite=y or post an error- I missed this when reviewing the patch. I don't care about capital letters too much - you're supposed to do -overwrite=yes anyway, and I'm not sure if -overwrite=Y is really useful. Line 206 is not obsolete, as the value was set by line 203, but it's somewhat strange that overwrite can be 'y', 'n' or 'ask'. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
