"LA2" posted a comment on pywikipedia.r10036. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10036#c32476
Commit summary for pywikipedia.r10036: New -overwrite=[yes|no] option for djvutext Patch by Lars Aronsson <[email protected]> Reference: pywikipediabot-Patches-3502676 LA2's comment: I was asked by Valhallasw to comment here. I submitted a patch to Sourceforge, that solved a real problem for me by adding a command line option to indicate whether all or none of the existing pages should be overwritten. I really would want to leave it there, and not get involved in refactoring the entire program. As I explained to Valhallasw on IRC, the program has many other real issues, such as not accepting PDF files. It's unclear to me why Pywikipedia is bug reported and stored on Sourceforge, but then code reviewed here on the Mediawiki wiki. Many strange things, that perhaps someone should fix some day, but for the moment, the current version (from svn) works fine for me, and that helps me to add books to Wikisource. This is my principle: to add and improve free content, while avoiding as far as possible to get bogged down in software development. If there is a document that guides the architecture of Pywikipedia (or Wikimedia related software in general), for example saying that if "y" means yes, then upper case "Y" should also be accepted, I'd be interested to read that document. It doesn't mean I will refactor all of the existing code base, but I would have some guidance when making minimalistic changes that solve real problems. Line 206 is not entirely obsolete. Yes, it can be removed, but I think it does provide some clarity to the human reader by restoring the value given at line 194, that was overwritten on line 203. It is true that combining -ask and -overwrite options gives a result that might not be intuitive. Perhaps this combination should be tested on line 250 in main, right after the "for arg" loop? _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
