"Khorn (WMF)" changed the status of Wikimedia.r1503 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1503#c32525
Old Status: new New Status: fixme Commit summary for Wikimedia.r1503: Added the ability to specify the number of contributions to batch for crg. See r1501. Khorn (WMF)'s comment: I just noticed: You probably don't want to return the result of drush_set_error, because if the error is successfully set it will most likely return true, and appear to drush as if you have passed your validaiton. This could cause the main control loop inside your module to partially (or fully) execute once, with a bad batch configuration. <br><br>I think you probably just want to set the error, and return false for the validation function. <br><br>This is still the case as of r1535. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
