"Khorn (WMF)" changed the status of Wikimedia.r1503 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1503#c32529
Old Status: new New Status: fixme Commit summary for Wikimedia.r1503: Added the ability to specify the number of contributions to batch for crg. See r1501. Khorn (WMF)'s comment: Ah, I see. Unfortunately, most IDEs looking at just the civicrm project probably won't be able to figure that out, and in an emergency situation that would leave some poor coder doing a recursive grep over a rather large codebase and probably not finding the drush code at the end of it all. <br>When things like this come up (and I certainly recognize that this is a stylistic choice, but it's one that we more or less already have policy on because it comes up so often), if the outcome is going to be unclear to somebody looking at the code for the first time, we should probably break it up anyway. In this case, it's not like we're even trading efficiency for readability, but we certainly do that some places. <br><br>Additionally: If they ever change this behavior in, say, some future drush upgrade, the validation function would break. Returning false explicitly here removes that possibility. _______________________________________________ MediaWiki-CodeReview mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
