On Wed, Mar 28, 2012 at 11:54 AM, Greg Sabino Mullane <[email protected]> wrote: > * It really shouldn't be giving me the option to +1 my own commit >
This is gerrit issue 308[0], and one that I'd really like to see fixed. Commenting on your own code is perfectly fine--you have to have a chance to respond to criticism. However I find the ability to +1 yourself confusing/useless as best and +2's of your own code to be actively harmful (except in emergency/site-ops type stuff) since it basically ducks the review process. -1/-2 of your own code is useful--it's great for "This is a work in progress, please do not merge yet but I'd like feedback" -Chad [0] http://code.google.com/p/gerrit/issues/detail?id=308 _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
