On 03/29/2012 09:20 AM, Chad wrote: > On Wed, Mar 28, 2012 at 2:05 PM, Rob Moen <[email protected]> wrote: >> I agree. Having 'you' or 'i' makes the message personal when the focus >> should remain on the commit itself. >> >> + 1 >> This patch needs improvement. | Needs improvement, this patch does. ( if >> we go with the yoda job ) >> > > I've combined a little bit of everyone's suggestions so far (other than Yoda). > > How does "There is a problem with this patchset, please fix" sound? > > -Chad
Sounds good to me. -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
