It sounds better. Shame on your that you don't like Yoda

On Thu, Mar 29, 2012 at 3:20 PM, Chad <[email protected]> wrote:
> On Wed, Mar 28, 2012 at 2:05 PM, Rob Moen <[email protected]> wrote:
>> I agree.  Having 'you' or 'i' makes the message personal when the focus
>> should remain on the commit itself.
>>
>> + 1
>> This patch needs improvement.  |  Needs improvement, this patch does.  ( if
>> we go with the yoda job )
>>
>
> I've combined a little bit of everyone's suggestions so far (other than Yoda).
>
> How does "There is a problem with this patchset, please fix" sound?
>
> -Chad
>
> _______________________________________________
> Wikitech-l mailing list
> [email protected]
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l

_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to