On Thu, Mar 29, 2012 at 8:24 PM, Tim Starling <[email protected]> wrote: > I don't really want Gerrit putting words into my mouth regardless of > how nice they sound. There will always be cases where the phrase is > inappropriate and offputting, regardless of which one you choose. > > How about "Set code review score to -1"? Then a more personal message > can be typed by the human doing the review. >
That doesn't work well the other terms. If you look at the list, they're all talking about the change. - This looks good to me, approved - Looks good to me, but someone else must approve - Set code review score to -1 - Do not submit *sings* One of these is not like the others...unless you're suggesting we change all of them to "Set code review score to +2," etc. -Chad _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
