Le 04/04/12 22:56, Roan Kattouw a écrit : <snip> >> What that means, is that a change could look fine (Verified + CR) and >> thus be merged by accident if someone with the correct right click the >> 'Submit Patch Set 1' button :-D >> >> No, that's not true. A change requires Code Review +2 before it can be > submitted, not +1. And only trusted reviewers have +2 powers.
So that would prevent me from accidentally submitting some code. :) >> OpenStack uses this because they have a policy that two core reviewers > must approve (i.e. two +2 reviews are needed) before something can be > merged. Because Gerrit allows merges after one +2, they implemented a > separate Approved category, and approvals are bureaucratic and based on the > presence of two +2s. Or at least that's the impression I got when I talked > to the OpenStack people at linux.conf.au . > > > Overall, I don't think we need this. The only reason I see to implement > this is because "+2" is a confusingly named concept, and it would be easier > to grok if we just had 3 categories that each just had -1 and +1. Indeed, it seems we do not need the Approve right and we can all safely ignore this thread. Thanks for the explanation! -- Antoine "hashar" Musso _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
