On Thu, Apr 5, 2012 at 11:20 AM, Platonides <[email protected]> wrote:
> If you submit a code review for a changeset and not a verification > status (only if it is not verified?), it throws you an error: > > Application Error > > Server Error > > Requires Verified > > I suspect it's a bug and we should ignore it but, can we get rid of it? > We don't want changesets dummily marked as verified just to please gerrit. > > This only happens if you click "Publish and Submit", which means "publish my comments and attempt to merge the commit". This fails because there is no Verified +1 review, so the commit doesn't satisfy the criteria for merging. If you click "Publish comment" (or whatever the caption of the other publish button is), this doesn't happen. Roan _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
