On Thu, Apr 5, 2012 at 11:37 AM, Platonides <[email protected]> wrote:
> On 05/04/12 20:23, Roan Kattouw wrote: > > This only happens if you click "Publish and Submit", which means "publish > > my comments and attempt to merge the commit". This fails because there is > > no Verified +1 review, so the commit doesn't satisfy the criteria for > > merging. If you click "Publish comment" (or whatever the caption of the > > other publish button is), this doesn't happen. > > > > Roan > > So in order to comment *and give it a score* you need to choose "Publish > comment"? > I wouldn't have associated that "submit" as meaning "merge". > > Yes, that's how it works. The Gerrit jargon is totally confusing, I agree. Roan _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
