On 04/11/2012 03:27 AM, Kim Eik wrote: > I have created a patch for the gallery tag and have been given the > following review. > > https://gerrit.wikimedia.org/r/4609 > > * JavaScript injection: you can inject javascript: URIs which execute > code when clicked > * plain links ("link=Firefox") are taken as relative URLs which will > randomly work or not work depending on where they're viewed from > * need parser test cases to demo it working > > So my questions are: > > What would be the recommended way of stripping away javascript from > uris? Are there any shared functions which do exactly this? > And how would i solve the plain links problem? do a regex check for an > absolute uri? e.g http://example.org/foo/bar? > And what is "parser test cases", phpunit tests? or some other form of testing? > > Thank you! > Kim Eik.
Hi, Kim, and thanks for the patch! I can answer your last question: https://www.mediawiki.org/wiki/Parser_tests You might also want to skim https://www.mediawiki.org/wiki/Testing_portal and https://www.mediawiki.org/wiki/Manual:MediaWiki_architecture Thanks! -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
