>So that is the change that will take some work--
>right now there's code to process uploading files, and
>code to save articles... the file upload code is not run on article text to
be saved.

A quick skim through the UploadBase.php file shows that the code for
checking SVG files is in UploadBase:: detectScriptInSvg( $filename ).  This
method creates a new XmlTypeCheck() with a callback to UploadBase
::checkSvgScriptCallback() which in turn checks each element and attribute
to make sure they are not blacklisted.

Why not make UploadBase:: detectScriptInSvg( $filename ) et al. a static
method, and replace the few references to $this that are found in UploadBase
::checkSvgScriptCallback() with static or self.

This was just a quick looking through, but it /at first glance/ does not
appear that it will require tremendous amounts of effect to make the code
for processing uploaded files work for saved pages.

The rest of the modifications that would be needed (creating new namespace,
modifying how pages are displayed, etc.) I can't begin to guess at the
difficulty of, but that one at least looks fairly straight forward.

Thank you,
Derric Atzrott


_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to