On Thu, Jul 19, 2012 at 4:40 PM, Platonides <[email protected]> wrote: > It should be possible to only bisect on the left-branch of merges. If > git doesn't have such feature, it should be added. In fact, it's very > likely that it's what it uses when start and end are in the same line, > but as the merged commits can also have that ancestor, it might also go > there. > > We would need to store multiple commits as non-fastforwards, even if > descending from head, but that's trivial. > What I have trouble with is in imagining the UI for reviewing a topic > branch, with perhaps several commits per "step". > > Always registering as a merge, has succh as storing the merger name as > the commiter, but I'd like keeping them as fest-forwards having for > one-commit changes. Yes, I suppose that's reasonable, if you no-ff multi-commit merges it should be fine.
I completely agree with you and Subbu re needing to have an interface for reviewing a multi-commit branch as a whole. I would prefer a multi-commit model over Gerrit's amend model, but only if the UI for followups is reasonable. I don't know of any existing tool that has this. In fact, Gerrit is the only tool I'm aware of where it's clear that the UI was designed with fixup commits in mind (even though they're amends, which I agree is suboptimal). Fixup commits tend to be a blind spot when people think about pre-commit review. Roan _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
