On Sep 25, 2012 12:15 PM, "IAlex" <[email protected]> wrote:
> Would it be possible to have the whole changes as an changeset on Gerrit?
> This would make review and comments much easier than having to do this on
this list.
>
Yes and no. The person that merges the branch can create a merge commit and
submit that for review (git checkout -b mergewikidata master && git merge
wikidata && git review) but Gerrit will not show the diff properly: it'll
either show just the conflict resolutions, or nothing at all. You can view
the full diff by fetching the commit on your localhost and using standard
git tools (e.g. git review -d 12345 && git show), but you won't be able to
use inline comments quite as nicely.

Roan
_______________________________________________
Wikitech-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to