Hello, I would consider https://bugzilla.wikimedia.org/show_bug.cgi?id=40653 (filed by Daniel Kinzler after one of my comments) as a blocker for this merge. Also Nikerabbit's comments in https://gerrit.wikimedia.org/r/#/c/25736/1/includes/Content.php lines 222 and following would be great to fix before the merge.
Cheers! Alexandre Emsenhuber (ialex) Le 3 oct. 2012 à 03:07, Rob Lanphier a écrit : > Hi everyone, > > We now at around the time that we planned to merge the ContentHandler branch > in. > > Questions: > * Daniel/others: have you submitted a merge commit for this? If not, > do you need help/clarification, or do you have it? > * People who reviewed Denny's faux commit[1] and left comments. Any > blockers, or mainly stylistic stuff? > > Everyone else, now is the last call before the merge. > > Rob > [1] Faux commit of ContentHandler branch: > <https://gerrit.wikimedia.org/r/#/c/25736/> > > _______________________________________________ > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
