On Thu, Dec 6, 2012 at 10:52 PM, Tim Landscheidt <t...@tim-landscheidt.de> wrote: >> That is all. The slow unit tests are no more run on patchset submission.
We really need them. The tests philosophy is "there is an issue with this change". The Jenkins philosophy is "automate as most as possible to discover them as soon as possible". Furthermore, one of the current Wikimedia politics is "get more technical contributors" and do outreach tout azimut. The tests are really important there, as they don't know each particularities of each class of the code (and I'm including myself in this area, there are MediaWiki classes I haven't get the opportunity to read yet). Should I really put logical constructors between these facts or the "we really need tests to run" is evident for all? > >> [...] > > I'm with Erik on this one who posted on the talk page in > March: > > | I understand the concern, but if we're creating a world > | where tests have to wait for developer review, we're doing > | CI the wrong way around. The whole point of automated > | testing is to minimize the need for human review, so we > | should aim to run as many tests as possible as early as > | possible. Both test performance and security considerations > | are problems to be gradually resolved in aiming for highest > | possible test execution for all code that gets submitted, > | and minimizing the need for human review on code which is > | obviously broken. > > Why not just add (more) slaves? Computing power is much > cheaper than developer time. I absolutely agree. -- Best Regards, Sébastien Santoro aka Dereckson http://www.dereckson.be/ _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
