On Jan 6, 2013, at 3:39 AM, Ori Livneh <o...@wikimedia.org> wrote: > > On Saturday, January 5, 2013 at 2:08 PM, Alex Monk wrote: > >> Okay then, so what query do you use to get a history of +1 and -1 reviews a >> user has made? >> >> > > The best I could come up with is: > > reviewer:krenair project:mediawiki/core -owner:krenair (label:CodeReview=1 OR > label:CodeReview=-1) > > https://gerrit.wikimedia.org/r/#/q/reviewer:krenair+project:mediawiki/core+-owner:krenair+(label:CodeReview%253D1+OR+label:CodeReview%253D-1),n,z > > It seems more useful to cast a wider net, though: > > reviewer:krenair -owner:krenair > > https://gerrit.wikimedia.org/r/#/q/reviewer:krenair+-owner:krenair,n,z > > I'll add them to the request on MediaWiki.org. >
Just pointing out the obvious but this returns all commits where *someone* did CR+1/-1 and where Krenair is in the reviewer list. Such as https://gerrit.wikimedia.org/r/#/c/38258/: where Bsitu did CR+1 and Alex no review on the final version but is in the reviewer/CC list. -- Krinkle _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l