On 15.01.2013 15:06, Tyler Romeo wrote: > I agree with Antoine. Commit messages are part of the permanent history of > this project. From now until MediaWiki doesn't exist anymore, anybody can > come and look at the change history and the commit messages that go with > them. Now you might ask what the possibility is of somebody ever coming > across a single commit message that has a typo in it, but when you're using > git-blame, git-bisect, or other similar tools, it's very possible.
And then they see a typo. So what? If you look through a mailing list archive or Wikipedia edit comments, you will also see typos. I'm much more concerned about scaring away new contributors with such nitpicking. > I'm not so sure about *every* commit, but I definitely agree that this > needs to be enforced more. If you're fixing something or adding a new > feature, there should be a bug to go with it. Every commit that is not trivial. This would be so much nicer if we had good integration between bug tracker and review system :/ -- daniel _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
