On 2015-11-02, Jason Ji <[email protected]> wrote: > Hi all, > > Sorry to be spamming this list due to my own incompetence. I'm basically > doing an upgrade-a-thon of our various extensions to the new extension > format, and therefore running into issues as I go. > > In a previous email I discussed a problem I was having with the fact that > the new extension registration doesn't support PHP constants, which I was > using for explicit dependencies. Now I'm working on upgrading another > extension where I use PHP constants to allow users to configure options for > my extension. > > My extension is called CommentStreams. In the old registration approach, > inside of CommentStreams.php, I had three constants defined: > > define('NS_COMMENTSTREAMS', 1000); > define('CS_COMMENTS_EXPANDED', 0); > define('CS_COMMENTS_COLLAPSED', 1);
You might want to see how ProofreadPage solved related problems: https://phabricator.wikimedia.org/T39483 and the fix in 98bb44055a9a44429ab40d9ff71375eb79379d24 by your truly (although at the time it didn't use NS_xxx anymore). ~saper _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
