On Wed, Apr 20, 2016 at 8:26 AM, René Pickhardt <[email protected]> wrote: > Hey Chad, > > I understand this but I also understand the documentation ( > https://www.mediawiki.org/wiki/%2B2 ) in a way that it says that Sebastian > and me should not review our own code. That is where my question was > aiming. Because obviously even with early code review we do not need every > time we make a git commit to exchange our work in our team a code review.
Waiting for peer code review on each patch can be very difficult when working on a small team and doing new development. Self-merges are generally ok when you are building something new from scratch that isn't deployed into the WMF production yet. All of your code will eventually need to get a full security and performance review before being approved for WMF production use. Find a workflow that works for you and your collaborators and don't get too hung up on the guidance that we give for production deployed code yet. Bryan -- Bryan Davis Wikimedia Foundation <[email protected]> [[m:User:BDavis_(WMF)]] Sr Software Engineer Boise, ID USA irc: bd808 v:415.839.6885 x6855 _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
