Hey Bryan, that is great to hear! Though this development has the clear goal to transfer our MOOC-Interface which is in use on wikiversity to production code as an extension. Therefor we wanted to involve the community right a way and adapt to the processes that are the common culture here.
best Rene On Wed, Apr 20, 2016 at 5:21 PM, Bryan Davis <[email protected]> wrote: > On Wed, Apr 20, 2016 at 8:26 AM, René Pickhardt > <[email protected]> wrote: > > Hey Chad, > > > > I understand this but I also understand the documentation ( > > https://www.mediawiki.org/wiki/%2B2 ) in a way that it says that > Sebastian > > and me should not review our own code. That is where my question was > > aiming. Because obviously even with early code review we do not need > every > > time we make a git commit to exchange our work in our team a code review. > > Waiting for peer code review on each patch can be very difficult when > working on a small team and doing new development. Self-merges are > generally ok when you are building something new from scratch that > isn't deployed into the WMF production yet. All of your code will > eventually need to get a full security and performance review before > being approved for WMF production use. Find a workflow that works for > you and your collaborators and don't get too hung up on the guidance > that we give for production deployed code yet. > > Bryan > -- > Bryan Davis Wikimedia Foundation <[email protected]> > [[m:User:BDavis_(WMF)]] Sr Software Engineer Boise, ID USA > irc: bd808 v:415.839.6885 x6855 > > _______________________________________________ > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > -- -- www.rene-pickhardt.de <http://www.beijing-china-blog.com/> Skype: rene.pickhardt mobile: +49 (0)176 5762 3618 office: +49 (0) 261 / 287 2765 fax: +49 (0) 261 / 287 100 2765 _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
