On 12 May 2016 at 14:26, Jon Robson <jdlrob...@gmail.com> wrote: > Gerrit is commonly used as a place to share works in progress early. > > This is great, but it has an unfortunate side effect of making it > harder for would-be reviewers to find patches that need reviewing > using this query: > > https://gerrit.wikimedia.org/r/#/q/(NOT+label:Verified%253D-1)+AND+(label:Code-Review%253D0+OR+NOT+(label:Code-Review%253D-1+OR+label:Code-Review%253D-2)),n,z > > Could I ask that as a norm, if you post a WIP patch that you also self -2 > it? >
I disagree with this suggestion. The convention to date is having "WIP" or "DONTMERGE" in the git commit title. What's wrong with that? > I'd love to get us to a place where > > https://gerrit.wikimedia.org/r/#/q/(NOT+label:Verified%253D-1)+AND+(label:Code-Review%253D0+OR+NOT+(label:Code-Review%253D-1+OR+label:Code-Review%253D-2)),n,z > is manageable that code gets merged left right and center :) > ​Use https://gerrit.wikimedia.org/r/#/q/(NOT+message:WIP)+AND+(NOT+message:DONTMERGE)+AND+(NOT+label:Verified%253D-1)+AND+(label:Code-Review%253D0+OR+NOT+(label:Code-Review%253D-1+OR+label:Code-Review%253D-2))+age:24w,n,z instead. J. -- James D. Forrester Lead Product Manager, Editing Wikimedia Foundation, Inc. jforres...@wikimedia.org | @jdforrester _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
