We definitely need consistency for any convention like this to be useful. Phabricator has the equivalent of self-2 in Differential: `arc diff --plan-changes`
It's a good convention, and I will try to adhere to the self-2 in addition to added WIP in the commit subject. On Thu, May 12, 2016 at 4:44 PM, Jon Robson <[email protected]> wrote: > I didn't know you could search message. Thanks. Even so.. the crux of > what I'm asking for is a reliable way to filter these out. Even with > the search you gave me I see "DONOTSUBMIT" in certain messages :) > > > On Thu, May 12, 2016 at 2:29 PM, James Forrester > <[email protected]> wrote: > > On 12 May 2016 at 14:26, Jon Robson <[email protected]> wrote: > > > >> Gerrit is commonly used as a place to share works in progress early. > >> > >> This is great, but it has an unfortunate side effect of making it > >> harder for would-be reviewers to find patches that need reviewing > >> using this query: > >> > >> > https://gerrit.wikimedia.org/r/#/q/(NOT+label:Verified%253D-1)+AND+(label:Code-Review%253D0+OR+NOT+(label:Code-Review%253D-1+OR+label:Code-Review%253D-2)),n,z > >> > >> Could I ask that as a norm, if you post a WIP patch that you also self > -2 > >> it? > >> > > > > I disagree with this suggestion. The convention to date is having "WIP" > or > > "DONTMERGE" in the git commit title. What's wrong with that? > > > > > > > >> I'd love to get us to a place where > >> > >> > https://gerrit.wikimedia.org/r/#/q/(NOT+label:Verified%253D-1)+AND+(label:Code-Review%253D0+OR+NOT+(label:Code-Review%253D-1+OR+label:Code-Review%253D-2)),n,z > >> is manageable that code gets merged left right and center :) > >> > > > > Use > > > https://gerrit.wikimedia.org/r/#/q/(NOT+message:WIP)+AND+(NOT+message:DONTMERGE)+AND+(NOT+label:Verified%253D-1)+AND+(label:Code-Review%253D0+OR+NOT+(label:Code-Review%253D-1+OR+label:Code-Review%253D-2))+age:24w,n,z > > instead. > > > > J. > > -- > > James D. Forrester > > Lead Product Manager, Editing > > Wikimedia Foundation, Inc. > > > > [email protected] | @jdforrester > > _______________________________________________ > > Wikitech-l mailing list > > [email protected] > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > > > > -- > Jon Robson > * http://jonrobson.me.uk > * https://www.facebook.com/jonrobson > * @rakugojon > > _______________________________________________ > Wikitech-l mailing list > [email protected] > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > _______________________________________________ Wikitech-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikitech-l
