hello, thanks a lot
for all your feedback.
So I have learned how to submit using "+2" (and I have updated successfully the repository)
I have also asked to change the repository
from "Merge review" to "Open push" here
I understand that with it I could directly push, although I don't think by now is
strictly necessary.
I have also reformatted the code which is now here
however, I have two issues:
1) when I use the command git clone "https://gerrit.wikimedia.org/r/mediawiki/extensions/CIForms"
it also downloads the .git folder, how can I avoid that or to cancel it from the remote folder ?
2) from this page https://www.mediawiki.org/wiki/Special:ExtensionDistributor/CIForms
it does not download the updated repository, which is the purpose I aimed for: how can I fix/update it ?
thanks
(Thomas)
Sent: Saturday, August 14, 2021 at 7:46 AM
From: "Kunal Mehta" <[email protected]>
To: [email protected]
Subject: [Wikitech-l] Re: reviewer for extension
From: "Kunal Mehta" <[email protected]>
To: [email protected]
Subject: [Wikitech-l] Re: reviewer for extension
Hi,
On 8/13/21 6:21 AM, Andre Klapper wrote:
> Is this about
> https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CIForms/+/663043
> as that is the only open changeset listed under
> https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CIForms ?
>
> I wonder if it makes sense to change the repository in Gerrit from
> "Merge review" to "Open push", assuming you are the sole developer?
> That would allow you to directly push (if I understand correctly).
As a policy reason, we don't allow master/main of MediaWiki
extensions/skins to be open push because it prevents having a space to
discuss the pushed commit. Also, it bypasses any configured CI,
potentially leaving the repo in a broken state.
However, if you're the sole/primary developer of an extension/skin, it's
totally fine to just +2 your own change right after uploading it.
-- Legoktm
_______________________________________________
Wikitech-l mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
On 8/13/21 6:21 AM, Andre Klapper wrote:
> Is this about
> https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CIForms/+/663043
> as that is the only open changeset listed under
> https://gerrit.wikimedia.org/r/q/project:mediawiki/extensions/CIForms ?
>
> I wonder if it makes sense to change the repository in Gerrit from
> "Merge review" to "Open push", assuming you are the sole developer?
> That would allow you to directly push (if I understand correctly).
As a policy reason, we don't allow master/main of MediaWiki
extensions/skins to be open push because it prevents having a space to
discuss the pushed commit. Also, it bypasses any configured CI,
potentially leaving the repo in a broken state.
However, if you're the sole/primary developer of an extension/skin, it's
totally fine to just +2 your own change right after uploading it.
-- Legoktm
_______________________________________________
Wikitech-l mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
_______________________________________________ Wikitech-l mailing list -- [email protected] To unsubscribe send an email to [email protected] https://lists.wikimedia.org/postorius/lists/wikitech-l.lists.wikimedia.org/
