Ove Kaaven wrote:
>
> On Sat, 19 Feb 2000, Steven Elliott wrote:
>
> > I moved the fix I originally submitted with my "Patch to generate
> > patches within the build" e-mail to a tool named "genpatch" in the
> > "tools" directory. I also removed the "-w" switch.
> >
> > It should be clear how to use this tool from the usage statement. For
> > example, the attached patch was generated with:
> > tools/genpatch -a tools/genpatch -c "A utility that generates patches
> > for submission to [EMAIL PROTECTED]"
>
> There are some issues I don't like about this thing, but I'll limit myself
> to these two things:
> 1. Always put /dev/null diffs LAST, after cvs diffs. If I remember right,
> "patch" may fail to recognize the cvs diffs if you put them first.
I tested it with "patch" version 2.5 on RedHat Linux 6.1. The following
seems to work:
patch -p0 < patches/a_patch.diff
Even when a_patch.diff contains both new files and cvs diff output.
How do you invoke "patch"? I can test that as well.
> 2. It'd be nice to be able to only diff the things I really want to
> submit (i.e. specify arguments to cvs diff).
Something that would act as a regular expression that files would have
to match in order to be included? Seems like a good idea. I'll look
into it.
> Perhaps the cvs error
> messages "Nothing known about that file" could make the script the file
> into the newfile-list to be diffed against /dev/null... your -a option
> would then be completely unnecessary.
That would make it easier to use. My only hesitation I have is that I
tend to have various bogus files in my build tree (files backed up to
.orig and such) that would get included that shouldn't. However,
combined with your previous suggestion of being able to specify which
files it would probably work well.
I'll wait about a week or so for additional feedback before submitting
an updated version.
--
Steven Elliott ([EMAIL PROTECTED])
