Gerald Pfeifer <[EMAIL PROTECTED]> writes:
> Seriously, code like
>
> #ifdef linux
> /* Copy of info from 2.2.x kernel */
> #define SG_MAX_SENSE 16 /* too little, unlikely to change in 2.2.x */
>
> really seems quite bad to me! One should never just copy code from system
> headers and I really think Alexandre never should have approved something
> like that.
Like it or not, in some cases copying system headers is the sensible
thing to do, and we are already doing it at several places. In this
specific case I don't know if it's really necessary, but the code has
been like that for a long time anyway.
> As a matter of fact I have been disappointed several times lately when
> Alexandre applied patches that broke Wine on non-Linux platforms due to
> typos or "there's nothing apart from Linux" coding. :-(
>
> What's the purpose of an extremely strict development model if even the
> simplest such issues are not caught during patch review?
I'm not gcc, I review the code for logical correctness, not syntax
errors. I know it can be frustrating when the code doesn't compile,
which is why I discourage #ifdef usage, but in some cases there is no
choice. If you are not using the same system as the majority of the
developers, you have to live with the occasional glitch (frankly, how
hard was it to fix it?)
Personally I prefer to have a WINASPI that works on Linux and may need
a couple of #ifdefs to compile on FreeBSD, than one that compiles
everywhere but doesn't work. And I'm not going to reject code
improvements on the off-chance that they may not always compile on
every system out there, especially when neither me nor the original
developer have any way to check it.
--
Alexandre Julliard
[EMAIL PROTECTED]
