On Tue, Apr 11, 2000 at 03:16:18AM +0200, Ove Kaaven wrote:
>
> > Log message:
> > Marcus Meissner <[EMAIL PROTECTED]>
> > Restructured DirectDraw. Split into X11 and DGA driver, and multiple
> > files/dirs for easier maintenance. Cleaned up structs and include
> > files. Reindented the code. Started the same for Direct3D. Driver
> > inclusion now done by using configure/Makefile/ELF constructor tricks.
>
> I'll just mention that right now DGA2 compilation (XF86 4.0) is seriously
> broken.
Yes, as I said in my submission, I did not have a XF 4.0 buildsystem.
(Since we are currently setting up one at work, I will fix it as soon as
it gets available.)
Sorry if it is broken right now, but I did not want to remove the DGA2 code
alltogether.
> Besides, I wonder if it's a memory leak since the "private" field is never
> freed in the DirectDrawSurface's Release routine?
Only a very small leak. It should be freed in dsurface/x11.c. Patch appended.
Ciao, Marcus
Changelog:
free private structure in Xlib_DDS_Release
Index: dsurface/x11.c
===================================================================
RCS file: /home/wine/wine/dlls/ddraw/dsurface/x11.c,v
retrieving revision 1.2
diff -u -r1.2 x11.c
--- dsurface/x11.c 2000/04/09 18:39:52 1.2
+++ dsurface/x11.c 2000/04/11 13:00:45
@@ -366,6 +366,7 @@
/* Free the clipper if present */
if(This->s.lpClipper)
IDirectDrawClipper_Release(This->s.lpClipper);
+ HeapFree(GetProcessHeap(),0,This->private);
HeapFree(GetProcessHeap(),0,This);
return S_OK;
}
