On Thu, 15 Jun 2000, Gerald Pfeifer wrote:

> In loader/dos/module.c an entire function is simply #ifdef-ed out:
> 
> #if 0
> BOOL MZ_CreateProcess( HANDLE hFile, LPCSTR filename, LPCSTR cmdline,
>                        LPCSTR env,
>                        LPSECURITY_ATTRIBUTES psa, LPSECURITY_ATTRIBUTES tsa,
>                        BOOL inherit, DWORD flags, LPSTARTUPINFOA startup,
>                        LPPROCESS_INFORMATION info )
> 
> Is there a particular reason for that? If so, that should be described
> in a comment. Else this snippet probably should be removed.

Well... DOS support was broken by Alexandre's "Address Space Separation",
so he probably just ifdef-ed out the DOS parts that didn't compile, since
he probably didn't feel like messing with it (it's a little messy code
anyway, I suppose), so he left the DOS support for someone else to fix.

Now actually, I have mostly done so; I am able to start some DOS apps, but
not as many as before the ASS yet, and I've changed large parts of DOS
support code, so it's also hard to separate into a set of independent
patches that I can submit. (Things I've done include: moved the lpDosTask
pointer away from NE_MODULE and into the PDB instead, also removing the
hModule parameter of the DOSMEM routines, cleaned up the DPMI
implementation, did more work for using the Win32 console routines,
rewritten parts of the DOSVM_* routines and much of the MZ_* routines...)

But I don't have time to work more on this currently. But if anyone want
the megapatch and would like to work on it (or think that I can just
submit said megapatch myself without more cleaning up or bugfixing) then I
can probably send it somehow...

Though since I seem to recall you were a FreeBSD person, I doubt you're
particularly interested, since the DOS support is currently only
implemented for Linux anyway...

Reply via email to