Peter Ganten <[EMAIL PROTECTED]> writes:

> This patch makes wine to allways store the full pathname of library files
> in the WINE_MODREF structure. For libraries which do not exist as real
> files on the system, a filename is constructed, using the system
> directory as the faked location of these libraries. 

I don't think your changes to MODULE_FindModule are correct. This will
break lookup of any dll that is not in the path, for instance
GetModuleHandle("foo.dll") must match foo.dll even if it was loaded
from a private directory. Appending the system directory should only
be done in BUILTIN32_LoadLibrary.

> This would use the builtin library BAR.DLL. Unfortunately because of
> this, the colon-sign (:) is not available any more to separate
> different loadorder overrides at the commandline, instead of this you
> can use the plus-sign (+) now. Example:
> 
> wine --dll shell,shell32=n+c:\\foo\\bar=b baz.exe
> 
> 16bit modules should not be affected by this patch.

While you are at it, I'd suggest removing the ability to specify
multiple dlls in the same option, and support repeated --dll options
instead. The option syntax is way too complicated IMO.

-- 
Alexandre Julliard
[EMAIL PROTECTED]

Reply via email to